Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

chore: remove duplicate creditCard definitions. #53

Merged
merged 1 commit into from
Jan 31, 2019
Merged

chore: remove duplicate creditCard definitions. #53

merged 1 commit into from
Jan 31, 2019

Conversation

michaelmcallister
Copy link
Contributor

It is not clear to me why they have been duplicated in the first case, so if I have missed something obvious please accept my apologies!

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          10       10           
  Lines         540      540           
=======================================
  Hits          511      511           
  Misses         15       15           
  Partials       14       14
Impacted Files Coverage Δ
payment.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dcad9...dc5a8bd. Read the comment docs.

@bxcodec
Copy link
Owner

bxcodec commented Jan 31, 2019

Thank you for the PR. I think this is a tech debt 😅
I also don't remember why this is duplicated

Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@bxcodec bxcodec changed the title Remove duplicate creditCard definitions. chore: remove duplicate creditCard definitions. Jan 31, 2019
@bxcodec bxcodec merged commit 6b3ea06 into bxcodec:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants