Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

adds support for FirstName of either male or female gender #28

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

perryao
Copy link
Contributor

@perryao perryao commented Aug 8, 2018

I need to generate a random first name of either gender, so added support for that here. From a user perspective, if they choose to define a struct with either TitleMale or TitleFemale, they should also use FirstNameMale or FirstNameFemale.

But if they only need a FirstName and a LastName, this makes it possible to generate Persons of random gender.

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #28 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   97.82%   97.83%   +0.01%     
==========================================
  Files           8        8              
  Lines         368      370       +2     
==========================================
+ Hits          360      362       +2     
  Misses          4        4              
  Partials        4        4
Impacted Files Coverage Δ
faker.go 95.23% <ø> (ø) ⬆️
person.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886f577...7d1e8bd. Read the comment docs.

Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxcodec bxcodec merged commit 1376d2e into bxcodec:master Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants