Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options pane location + update to 1.5.1 #44

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

thebluepotato
Copy link
Contributor

The (very) recent release of 1.5.0 moved the options pane XHTML inside the content folder. As this is cleaner, I changed the code to reflect it. Also a good opportunity to test if updates to 1.5.1 will work! Fixes #43

@thebluepotato
Copy link
Contributor Author

@bwiernik Sorry for the hassle

@bwiernik bwiernik merged commit bf70d0b into bwiernik:master Aug 9, 2024
@bwiernik
Copy link
Owner

bwiernik commented Aug 9, 2024

No problem -- I don't have a build script for the .xpi set up on my current machine -- could you make one and post it here?

@thebluepotato
Copy link
Contributor Author

No problem -- I don't have a build script for the .xpi set up on my current machine -- could you make one and post it here?

I've been updating the BAT script throughout the PR, but I don't have Windows. What's your platform? Would GitHub actions be easier to use? I guess that would allow automation of version numbers across the manifests.

@bwiernik
Copy link
Owner

bwiernik commented Aug 9, 2024

I'm working on a Mac at this point

@thebluepotato
Copy link
Contributor Author

Ok so do I, I'll draft something over the weekend. In the meantime, if you want to release 1.5.1, you can do the same as you did for .0, namely zip all folders, js files, the JSON manifest, install.rdf and chrome.manifest. I've moved options.xhtml so now it should indeed stay in the content folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The settings page is empty
2 participants