Additional builtin testing and fixes #85
Merged
+64
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4813503185
💛 - Coveralls |
|
By the way, sorry if I stole your thunder on this @cgahr. I was originally going to just include the additional tests in this PR to address @bwhmather's concern in #82 of our current failure to detect these missing builtins as part of our test suite, but then this solution presented itself to me 🤷♂️ |
bwhmather
approved these changes
Apr 27, 2023
bwhmather
reviewed
Apr 27, 2023
| @@ -0,0 +1 @@ | |||
| print(dir()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional builtin tests and provides a simpler, albeit dumber, implementation of #82.
In addition to supporting the
__path__builtin, as done in #82, the tests introduced by this PR showed a lack of support for the following builtins:__annotations____builtins____cached__Support for these builtins has also been added as part of this PR.
Rationale for this approach over the approach in #82:
The
_builtins.pyfile already contains an extraordinary number of builtins which are conditionally defined. For instance,WindowsErroris only defined on Windows systems,__annotations__is only defined in the__main__scope,__file__may or may not be defined depending on if the source is defined in a file or not, etc... Since may of these conditions are complex and possibly not even know to us since they depend on the runtime, we are simply assuming they exist. I see no reason to treat__path__any different.