Skip to content

Fix rtol #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwengals merged 1 commit into from
Aug 16, 2017
Merged

Fix rtol #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pymc3/tests/test_tuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ def test_mle_jacobian():
with model:
map_estimate = find_MAP(model=model)

np.testing.assert_allclose(map_estimate["mu_i"], truth)
rtol = 1E-5 # this rtol should work on both floatX precisions
np.testing.assert_allclose(map_estimate["mu_i"], truth, rtol=rtol)

start, model, _ = models.simple_normal(bounded_prior=True)
with model:
map_estimate = find_MAP(model=model)

np.testing.assert_allclose(map_estimate["mu_i"], truth)
np.testing.assert_allclose(map_estimate["mu_i"], truth, rtol=rtol)