Add option to prevent config files from writing #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw2
requested changes
Aug 27, 2021
| if getattr(a, "is_write_out_config_file_arg", False)] | ||
| output_file_paths = [a for a in output_file_paths if a is not None] | ||
| self.write_config_file(namespace, output_file_paths, exit_after=True) | ||
| if ignore_write_args: |
There was a problem hiding this comment.
I think this should be if not ignore_write_args:
| @@ -480,6 +480,7 @@ def parse_known_args( | |||
| config_file_contents=None, | |||
| env_vars=os.environ, | |||
| ignore_help_args=False, | |||
| ignore_write_args=False, | |||
There was a problem hiding this comment.
I think this should be named
ignore_write_out_config_file_args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I need to call
parse_known_argsto finish the contruction of my ArgumentParser instance. Thus, I don't want it to just write the config and exit. This PR adds a flagignore_write_argsto theparse_known_argsmethod. When True, this prevents the config files from running.If this change is desired, please advise on any additional change that would need to be made to support this feature (places where to change the docs / etc).
(My editor also removed whitespace, I can undo that the maintainers would like to keep the diff minimal)