-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Testing linter and implements a test suite framework for mllint #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovide JUnit XML test report and Cobertura-compatible XML coverage report that will be analysed for test completion and coverage. Implements checking test completion stats from JUnit XML
…nfigurable, as multiple tests trying to configure the same linter object before running creates race conditions
…atload of tests for it
…targets. Implements better (and more configurable) check for whether a project has at least a certain amount of test files, or a certain ratio of test files to other files
…conforms to the intendede intuition, updates details and descriptions of all `testing/` rules and `testing` category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
This MR implements a linter for the
testing
category, along with several rules that check for how many tests there are in a project, whether these tests pass and what kind of line test coverage they achieve.Additionally, while implementing this, I felt inspired to build a better testing framework for
mllint
itself, such that it is easier to build test suites for linters.Finally, the
mllint config
command now also has support for a--toml
flag to output a TOML config snippet instead of YAML.