Specify peer dependencies and build Docker images #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt`'s analyses. Can be installed with `pip install mllint[tools]` when released
… and publish `mllint` Docker images for Python 3.6, 3.7, 3.8 and 3.9
…rs and describe / config also matching on partial rule slugs
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 86.96% 86.96%
=======================================
Files 42 42
Lines 790 790
=======================================
Hits 687 687
Misses 71 71
Partials 32 32 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, when this is merged and a tag is created for this, then Docker images for
mllintwill be published tobvobart/mllinton Docker Hub.Also, it is now possible to do
pip install mllint[tools]to installmllintalong with all of the Python tools that it uses for its analysis. These are not actual dependencies ofmllint, sincemllintcan run without them and not every project needs them, so they're optional dependencies. Additionally, we want users ofmllintto place these dependencies in their own project by themselves. Sadly, the Python ecosystem doesn't havepeerDependencieslike NPM packages have, so optional dependencies is the best we can do.