Reduce unnecessary renders for CellMeasurer in Grid #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
codecov-io
Jan 15, 2018
Repository owner
deleted a comment from
codecov-io
Jan 15, 2018
|
I feel good enough about this to move forward and try it. Will roll back if necessary. |
|
FWIW, I pulled the branch in our project where we use And BTW, thanks for this awesome library :) |
|
Thanks for double checking!
…On Mon, Jan 15, 2018 at 12:26 PM Damien Varron ***@***.***> wrote:
FWIW, I pulled the branch in our project where we use CellMeasurer and
nothing broke.
And BTW, thanks for this awesome library :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#969 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABznVlbUZYx9fPLrHBvKRs7BayUxL9pks5tK7RpgaJpZM4Re1Ul>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized this morning that when
CellMeasureris used, it causesCellSizeAndPositionManagerto always render every cell in a given column or row regardless of whether measurements have already been collected for those cells. This was not the intent of that code.I believe I've fixed this to only render all cells initially (per the need explained via the inline comments). Local smoke testing seems good. Automated tests pass.