Added right-click event handler. #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DamianOsipiuk
commented
Jul 17, 2017
DamianOsipiuk
commented
- test added
- docs modified
- test added - docs modified
|
Is it Table only feature? |
|
I don't see any |
|
Yes, this is a |
|
Thanks for the PR! My only requests were alpha-sorting nits so I went ahead and made them myself 😄 |
bvaughn
reviewed
Jul 17, 2017
| @@ -25,6 +25,7 @@ This component expects explicit `width` and `height` parameters. | |||
| | onHeaderClick | Function | | Callback invoked when a user clicks on a table header. `({ columnData: any, dataKey: string, event: Event }): void` | | |||
| | onRowClick | Function | | Callback invoked when a user clicks on a table row. `({ event: Event, index: number, rowData: any }): void` | | |||
| | onRowDoubleClick | Function | | Callback invoked when a user double-clicks on a table row. `({ event: Event, index: number, rowData: any }): void` | | |||
| | onRowRightClick | Function | | Callback invoked when a user right-clicks on a table row. `({ event: Event, index: number, rowData: any }): void` | | |||
There was a problem hiding this comment.
Thanks for updating docs too! 😄
nit: Docs should be alpha-sorted
| 3 | ||
| ]); | ||
| }); | ||
| }); |
| @@ -12,14 +12,21 @@ export default function defaultRowRenderer({ | |||
| key, | |||
| onRowClick, | |||
| onRowDoubleClick, | |||
| onRowRightClick, | |||
|
This feature has been released in version 9.10.0. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.