Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handleScroll for handling external scroll events #693

Merged
merged 2 commits into from
Jun 3, 2017

Conversation

5angel
Copy link
Contributor

@5angel 5angel commented Jun 2, 2017

Adds functionality to support easier intergration with custom scrollbars.

See discussion thread:
#692

@bvaughn
Copy link
Owner

bvaughn commented Jun 3, 2017

Thanks for submitting this PR.

I added a test for the new method and renamed it to handleScrollEvent to hopefully reduce confusion/ambiguity between it and the scrollToPos method.

@bvaughn bvaughn merged commit 6bd27e2 into bvaughn:master Jun 3, 2017
@bvaughn
Copy link
Owner

bvaughn commented Jun 10, 2017

I just published this feature to NPM as [email protected], tagged next. If you'd like to test it pre-release you can via:

npm install react-virtualized@next

Assuming no problems are reported with the RC, this feature will go out with 9.8.0 sometime this weekend. 😁

@bvaughn
Copy link
Owner

bvaughn commented Jun 13, 2017

Haven't heard anything negative about the RC so I just released 9.8.0

@5angel
Copy link
Contributor Author

5angel commented Jun 13, 2017

nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants