Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aria roles for table headers and cells #681

Merged
merged 2 commits into from
May 20, 2017
Merged

Fix aria roles for table headers and cells #681

merged 2 commits into from
May 20, 2017

Conversation

jchen527
Copy link
Contributor

Fixes #680.

  • Add id, aria role, and aria sort to table column headers
  • Add aria describedby and role to table cells

@jchen527
Fix aria roles for table headers and cells
3801ce3 
Fixes bvaughn#680.
- Add id, aria role, and aria sort to table column headers
- Add aria describedby and role to table cells
@bvaughn
Copy link
Owner

bvaughn commented May 17, 2017

I'm traveling at the moment and it's late- so I'll give this a real review later. But at a glance it looks great. Thanks!

@bvaughn bvaughn merged commit b6c4674 into bvaughn:master May 20, 2017
@bvaughn
Copy link
Owner

bvaughn commented May 20, 2017

Thanks!

@bvaughn
Copy link
Owner

bvaughn commented May 20, 2017

This has been released via 9.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchen527 @bvaughn