Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typeof function instead of instanceof Function #596

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

rickychien
Copy link
Contributor

@rickychien rickychien commented Feb 25, 2017

Using instanceof Function would be error prone and always return false if the Function instance comes from another iframe window,. Replace it by typeof check can be safer.

@bvaughn
Copy link
Owner

bvaughn commented Feb 25, 2017

Thanks @rickychien! This looks like a solid change. 😄

@bvaughn bvaughn merged commit 4fefef7 into bvaughn:master Feb 25, 2017
@rickychien rickychien deleted the typeof branch February 26, 2017 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants