Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in CellSizeCache usage example #443

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Fix minor typo in CellSizeCache usage example #443

merged 1 commit into from
Oct 21, 2016

Conversation

clauderic
Copy link
Contributor

:)

@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 98.18% (diff: 100%)

Merging #443 into master will not change coverage

@@             master       #443   diff @@
==========================================
  Files            61         61          
  Lines          4234       4234          
  Methods         897        897          
  Messages          0          0          
  Branches        319        319          
==========================================
  Hits           4157       4157          
  Misses           77         77          
  Partials          0          0          

Powered by Codecov. Last update 42a4155...e160233

@clauderic
Copy link
Contributor Author

clauderic commented Oct 21, 2016

On a side-note, I'm curious about CellSizeCache. Currently, it stores and does lookups based on row/cell indexes.

In a scenario where you may have elements that shift indexes but always remain the same size (for instance, when a list is reordered with react-sortable-hoc), what are your thoughts on a CellSizeCache implementation that would do lookup based on a cell's key property instead? (and, if no key is provided fallback on the index)

@bvaughn
Copy link
Owner

bvaughn commented Oct 21, 2016

Ha! Look at that. Thanks buddy 😄

@bvaughn bvaughn merged commit 8e52b3f into bvaughn:master Oct 21, 2016
@clauderic clauderic deleted the fix-documentation branch October 21, 2016 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants