-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 7 #206
Conversation
… to ({ index: number })
Big +1 on named arguments -- couldn't find a way to comment on that on the wiki. |
Would you accept PRs on some of these conversions for this branch? I'm already dinking around in FlexTable & FlexColumn for work stuff, so if you wouldn't mind, I could take on those methods you have slated for updating in the wiki. |
Hey @MikeMcElroy! Thanks for the input and the offer to help! That's awesome. :) I'm working my way through the named parameters this evening. Just finished I'd be happy to share the load though I wonder if we might step on each other's toes a bit. If you're working this evening, feel free to send me some PRs into this branch- maybe work your way from the bottom of the table up? :) |
We can chat in Gitter. |
* upstream/version-7: Updated signature of InfiniteLoader's :isRowLoaded. Updated signature of VirtualScroll's :rowHeight function. Updated signature for VirtualScroll's :rowRenderer
Implement named parameters in certain functions and clean up
…ber): string to ({ index: number }): string
… ({ index: number }): void
…verage for this param to Collection and Grid.
…uld link to them individually
…d Collection. Updated docs and tests.
FYI @MoOx~ I've just published version |
Performance tests aren't showing anything alarming- but it's gotten too late to feel comfortable with a release. Look for 7.0 in the morning. :) |
Backwards incompatible changes
Backwards compatible changes
isScrolling
parameterMiscellaneous
CellMeasurer
component