Update bug fix in #1642 to also reset isScrolling #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After further testing, I've found that after `handleWindowScrollEvent` is called we also need to force the `isScrolling` state variable to turn back to false (otherwise there might be issues with rendering rows that depend on `isScrolling`).
yamadapc
deleted the
issue/fix-reset-is-scrolling-after-handleWindowScrollEvent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further testing, I've found that after
handleWindowScrollEventis called we also need to force the
isScrollingstate variable to turnback to false (otherwise there might be issues with rendering rows that
depend on
isScrolling).