fix: masonry scroll handler should rely on event.currentTarget issue#1414 #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of event.target
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 59 59
Lines 1742 1742
=======================================
Hits 1574 1574
Misses 168 168
Continue to review full report at Codecov.
|
wuweiweiwu
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1414
The scroll handler should rely only on the scrolltop of event.currentTarget as any of the descendant elements' scroll event will propagate up to the container element. Relying on event.target seems incorrect.
Added a test case which fails if event.target.scrolltop is used.
Also, updated the function
simulateScrollin spec file. As passing currentTarget toSimulateis not supported ( facebook/react#4950 ), changed thesimulateScrollfunction to set the scrollTop on the desired element.