Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(badge): npm badge links to npmjs.com #1146

Merged
merged 1 commit into from
Jun 21, 2018
Merged

docs(badge): npm badge links to npmjs.com #1146

merged 1 commit into from
Jun 21, 2018

Conversation

SpainTrain
Copy link
Contributor

@SpainTrain SpainTrain commented Jun 20, 2018 •
edited
Loading

npm badges often link to the npm package description for convenience. I noticed this because I clicked the badge to view the npm package description page.

Testing
  1. In the PR diff, click the "Display the rich diff" button to see Markdown rendered correctly.

Before submitting a pull request, please complete the following checklist:

  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.

This change is Reviewable

wuweiweiwu
wuweiweiwu approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice catch

@wuweiweiwu wuweiweiwu merged commit a360210 into bvaughn:master Jun 21, 2018
@dependencies dependencies bot mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpainTrain @wuweiweiwu