No setState(null)
#1129
Merged
No setState(null)
#1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Jun 1, 2018
| const stateUpdate = {...prevState, needToResetStyleCache: false}; | ||
| stateUpdate.instanceProps.scrollbarSize = getScrollbarSize(); | ||
| stateUpdate.instanceProps.scrollbarSizeMeasured = true; | ||
| return stateUpdate; |
There was a problem hiding this comment.
Is it ok here to mutate state?
There was a problem hiding this comment.
I think so. previously it was this before the gDSFP migration
And since I need to set stuff on instanceProps I use prevState as a base
wuweiweiwu
commented
Jun 1, 2018
source/Grid/Grid.js
Outdated
| stateUpdate.needToResetStyleCache = false; | ||
| this.setState(stateUpdate); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Forgot about this. Will remove
TrySound
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1119
react 15 throws warning when
setStateis called withnullor{}