Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a more friendly height/width value for CellMeasurer cell styles #593

Closed
bvaughn opened this issue Feb 24, 2017 · 3 comments
Closed
Assignees

Comments

@bvaughn
Copy link
Owner

bvaughn commented Feb 24, 2017

A user submitted this Plnk demonstrating a problem where a row wasn't resizing correctly when measure was called. The fix (shown in this Plnk) was to set the cell's style with height: 'auto' so it could grow bigger than its initial measurement.

This isn't intuitive for users. I believe it should be possible for defaultCellRangeRenderer to set width or height to "auto" automatically when CellMeasurer is being used.

@bvaughn bvaughn self-assigned this Feb 24, 2017
@bvaughn
Copy link
Owner Author

bvaughn commented Feb 24, 2017

This feature, as described in the issue summary, would not be a good idea. Grid relies on forcing a width/height so that all cells in a given row/column share a consistent size. If we set "auto" they would all tight-fit and it would look back.

However we still need to handle the case where the measure callback is used after initial measurements. I think the thing to do might be to just-in-time set the height or width to "auto" before measuring...

bvaughn pushed a commit that referenced this issue Feb 24, 2017
@bvaughn
Copy link
Owner Author

bvaughn commented Feb 24, 2017

Resolved via b06e2a9

@bvaughn bvaughn closed this as completed Feb 24, 2017
@bvaughn
Copy link
Owner Author

bvaughn commented Feb 24, 2017

Released in 9.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant