Skip to content

Don't move selection unless search text increased length #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 1 commit into from
Apr 5, 2019
Merged

Don't move selection unless search text increased length #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/devtools/views/Components/TreeContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,10 @@ function reduceSearchState(store: Store, state: State, action: Action): State {
}

// Changes in search index or typing should override the selected element.
if (
searchIndex !== prevSearchIndex ||
searchText.indexOf(prevSearchText) === 0
) {
const didAddToSearchText =
searchText.length > prevSearchText.length &&
Copy link
Collaborator Author

@gaearon gaearon Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is new.

searchText.indexOf(prevSearchText) === 0;
if (searchIndex !== prevSearchIndex || didAddToSearchText) {
if (searchIndex === null) {
selectedElementIndex = null;
selectedElementID = null;
Expand Down