Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support drives other than C:\ on Windows #3

Open
neojp opened this issue Jul 13, 2019 · 0 comments
Open

Support drives other than C:\ on Windows #3

neojp opened this issue Jul 13, 2019 · 0 comments

Comments

@neojp
Copy link

neojp commented Jul 13, 2019

Related issues:
buttercup/buttercup-desktop#708
buttercup/buttercup-browser-extension#206
buttercup/buttercup-browser-extension#232
neojp added a commit to neojp/secure-file-host that referenced this issue Jul 14, 2019
@neojp
Support drives other than C:\ on Windows
cfc797e 
Edited `filesystem.js` functions to support Windows drives
- `getDirectoryContents` shows a list of Windows drives when requested `/` root path
- Subsequent paths will be formatted as `/<drive letter>/<path>`. Eg. `/c/Users/neojp/Desktop/archive.bcup`
- A new function `normalizeWindowsPath` will convert server request paths into resolved Windows paths
  `/c/Users/neojp/Desktop/archive.bcup` -> `c:\\Users\\neojp\\Desktop\\archive.bcup`

Fixes buttercup#3
@neojp neojp mentioned this issue Jul 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support drives other than C:\ on Windows neojp/secure-file-host
1 participant
@neojp