Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich valueChanged event to include source #43

Merged
merged 8 commits into from
Mar 20, 2024

Conversation

perry-mitchell
Copy link
Member

@perry-mitchell perry-mitchell commented Mar 20, 2024

As per title. The login tracker class still emits changes even if they're applied using the helper methods.

This PR adds a new source property to the valueChanged event that lists fill or keypress as the event source, so consumers can track what updated the form: Login details being filled programmatically, or the user typing their information in manually.

@perry-mitchell perry-mitchell self-assigned this Mar 20, 2024
@perry-mitchell perry-mitchell changed the title Prevent login tracker emit on manual change Enrich valueChanged event to include source Mar 20, 2024
@perry-mitchell perry-mitchell merged commit d625aa2 into master Mar 20, 2024
3 checks passed
@perry-mitchell perry-mitchell deleted the fix/tracker_no_emit_on_apply branch March 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant