Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Async task to queue post_summary jobs for the next day #285

Merged
merged 9 commits into from
Jul 8, 2020

Conversation

alysivji
Copy link
Member

@alysivji alysivji commented Jul 8, 2020

Part of #260

What does this do

  • convert CRON job to post message to CRON job that schedules post message jobs for the next day
  • currently works when you pass in a workspace id, but it can be generalized for all active workspaces
    • we need to roll this out by adding an active / enabled boolean field

Why are we doing this

This will allow us to add additional installations without having to do work on our side.

How should this be tested

  • added a unit test for the CLI job
  • tests around the job

Migrations

  • cleaning up previous task Model) that was truncated
  • adding additional fields
  • TODO make into a single migration

Dependencies

n/a

Callouts

n/a

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #285 into master will increase coverage by 0.03%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   96.56%   96.60%   +0.03%     
==========================================
  Files          71       71              
  Lines        1952     1975      +23     
==========================================
+ Hits         1885     1908      +23     
  Misses         67       67              
Impacted Files Coverage Δ
...beaver/apps/github_integration/summary/workflow.py 96.55% <92.30%> (-3.45%) ⬇️
busy_beaver/apps/github_integration/cli.py 100.00% <100.00%> (+5.88%) ⬆️
busy_beaver/common/models.py 100.00% <100.00%> (ø)
busy_beaver/toolbox/rq.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f70a52...7479205. Read the comment docs.

@alysivji alysivji merged commit 49f0ec9 into busy-beaver-dev:master Jul 8, 2020
@alysivji alysivji deleted the queue-chipy-post-task branch September 19, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants