Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

First iteration of settings page #280

Merged
merged 4 commits into from
Jul 6, 2020

Conversation

alysivji
Copy link
Member

@alysivji alysivji commented Jul 6, 2020

Start of #258

What does this do

  • add Flask-WTForms to the project
  • add forms for timezone (info is saved in database, but we do nothing with it)

Why are we doing this

Need a better way for admins to modify settings.

How should this be tested

no tests right now, this functionality is not connected to the rest of the app

Migrations

adding nullable columns to GitHub Summary Configuration table.

Dependencies

n/a

Callouts

n/a

@codecov-commenter
Copy link

Codecov Report

Merging #280 into master will decrease coverage by 1.22%.
The diff coverage is 68.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   97.11%   95.89%   -1.23%     
==========================================
  Files          68       71       +3     
  Lines        1874     1950      +76     
==========================================
+ Hits         1820     1870      +50     
- Misses         54       80      +26     
Impacted Files Coverage Δ
busy_beaver/apps/web/views.py 60.00% <44.44%> (-40.00%) ⬇️
busy_beaver/apps/web/workflows.py 60.00% <60.00%> (ø)
busy_beaver/common/wrappers/slack.py 95.08% <66.66%> (-3.10%) ⬇️
busy_beaver/apps/github_integration/models.py 100.00% <100.00%> (ø)
busy_beaver/apps/web/forms.py 100.00% <100.00%> (ø)
busy_beaver/common/datetime_utilities.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e729f22...0439265. Read the comment docs.

@alysivji alysivji merged commit 431f23f into busy-beaver-dev:master Jul 6, 2020
@alysivji alysivji deleted the settings-page branch September 19, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants