Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Sign-in with Slack #274

Merged
merged 13 commits into from
Jul 5, 2020
Merged

Conversation

alysivji
Copy link
Member

@alysivji alysivji commented Jul 5, 2020

Closes #263

What does this do

Adds /busybeaver settings command that allows authorized users to access the settings page.

Why are we doing this

We need a way for workspace admins to modify settings.

How should this be tested

Tested locally; need to write unit tests.

Migrations

Added a slack_user table.

Dependencies

n/a

Callouts

  • update Staging and Production oauth callbacks
  • add redirect_uri to slack install oauth callback
  • clean up callbacks
  • use slack_user for all Slack integrations

@codecov-commenter
Copy link

Codecov Report

Merging #274 into master will increase coverage by 0.06%.
The diff coverage is 98.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   97.25%   97.31%   +0.06%     
==========================================
  Files          68       68              
  Lines        1747     1861     +114     
==========================================
+ Hits         1699     1811     +112     
- Misses         48       50       +2     
Impacted Files Coverage Δ
busy_beaver/models.py 100.00% <ø> (ø)
...sy_beaver/apps/slack_integration/oauth/workflow.py 97.36% <95.00%> (-2.64%) ⬇️
busy_beaver/apps/slack_integration/api/__init__.py 100.00% <100.00%> (ø)
busy_beaver/apps/slack_integration/api/oauth.py 100.00% <100.00%> (ø)
busy_beaver/apps/slack_integration/models.py 100.00% <100.00%> (ø)
..._beaver/apps/slack_integration/oauth/oauth_flow.py 100.00% <100.00%> (ø)
...usy_beaver/apps/slack_integration/slash_command.py 100.00% <100.00%> (ø)
busy_beaver/clients.py 100.00% <100.00%> (ø)
busy_beaver/common/wrappers/slack.py 98.18% <100.00%> (+0.22%) ⬆️
busy_beaver/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3b326...51ef331. Read the comment docs.

@alysivji alysivji merged commit 7296006 into busy-beaver-dev:master Jul 5, 2020
@alysivji alysivji deleted the signing-with-slack branch July 5, 2020 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign-in with Slack
2 participants