Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Removing polling endpoints and async tasks #250

Merged
merged 9 commits into from
Apr 15, 2020

Conversation

alysivji
Copy link
Member

@alysivji alysivji commented Apr 15, 2020

Part of #248

What does this do

Remove poller BluePrint. Remove async tasks as we are now using Kubernets CRON jobs to run commands.

Keeping Async Task database tables around. We don't need to delete this data and pattern. Might have to use it later.

Why are we doing this

Don't need this code anymore

How should this be tested

n/a

Migrations

[TODO]

Dependencies

n/a

Callouts

  • probably should test this out in staging just to make sure everything is okay

@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #250 into master will increase coverage by 1.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   96.07%   97.51%   +1.43%     
==========================================
  Files          71       64       -7     
  Lines        1861     1690     -171     
==========================================
- Hits         1788     1648     -140     
+ Misses         73       42      -31     
Impacted Files Coverage Δ
busy_beaver/apps/upcoming_events/workflow.py 100.00% <ø> (ø)
busy_beaver/blueprints.py 100.00% <ø> (ø)
busy_beaver/models/task.py 100.00% <ø> (ø)
busy_beaver/app.py 93.33% <100.00%> (-0.15%) ⬇️
...usy_beaver/apps/github_integration/summary/task.py 97.43% <100.00%> (+1.43%) ⬆️
busy_beaver/apps/retweeter/task.py 100.00% <100.00%> (ø)
...beaver/apps/upcoming_events/event_database/task.py 100.00% <100.00%> (ø)
busy_beaver/toolbox/helpers.py 92.30% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8814fb...fc36746. Read the comment docs.

@alysivji alysivji merged commit cbfc972 into busy-beaver-dev:master Apr 15, 2020
@alysivji alysivji deleted the remove-poller-blueprint branch April 15, 2020 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants