Skip to content
This repository was archived by the owner on Oct 21, 2024. It is now read-only.

post_upcoming_events task requires workspace ID #241

Merged

Conversation

alysivji
Copy link
Member

What does this do

Adding a workspace_id parameter to the post_upcoming_events job

Why are we doing this

Creating a staging environment for Kubernetes requires the full app to work for more than 1 workspace.

How should this be tested

Modified code, do tests still pass? We're good.

Migrations

n/a

Dependencies

n/a

@codecov-io
Copy link

Codecov Report

Merging #241 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   96.11%   96.12%   +0.01%     
==========================================
  Files          71       71              
  Lines        1855     1860       +5     
==========================================
+ Hits         1783     1788       +5     
  Misses         72       72              
Impacted Files Coverage Δ
busy_beaver/apps/upcoming_events/workflow.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e07166...f9be113. Read the comment docs.

@alysivji alysivji merged commit cc51e9b into busy-beaver-dev:master Apr 12, 2020
@alysivji alysivji deleted the upcoming-events-workspace-id branch April 12, 2020 19:58
@alysivji alysivji mentioned this pull request Apr 15, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants