This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Duplicate polling tasks as Flask CLI commands #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do
Converting all polling CRON jobs to command line jobs that can be run as Kubernetes
CronJobs. The CronJob primitive is a great way to run and monitor jobs in a cluster.Leveraging the Click framework to building out command-line utilities that comes with Flask.
Why are we doing this
Continuing pre-Kubernetes migration work.
How should this be tested
Added tests around commands. Do tests pass with good coverage?
Migrations
n/a
Dependencies
n/a
Callouts
This might not be 100% ready for primetime, i.e. missing logging. That's okay. It doesn't change existing functionality and we will be polishing it up before it is used.