This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Do not require HTTPS on healthcheck endpoint #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do
Healthcheck endpoint doesn't need to be HTTPS
Flask Talisman forces all traffic to HTTPS, including internal traffic. Isn't usually isn't a problem as traefik routes all traffic to HTTPS.
When I was building out a staging environment on Kubernetes, the readiness probe was having issues with HTTPS. This fix causes everything to work.
Callouts
Healthcheck endpoints don't really need to be HTTPS, they can also be HTTP for internal use
Dependencies
n/a