Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporting LinkParams and UILinkParams types #718

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix exporting LinkParams and UILinkParams types #718

merged 1 commit into from
Oct 6, 2022

Conversation

bertdeblock
Copy link
Contributor

Closes #717.

@bertdeblock
Copy link
Contributor Author

@buschtoens Would you mind checking if this change is correct?

Copy link
Owner

@buschtoens buschtoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

Sorry, that this PR has slipped my attention.

@buschtoens buschtoens merged commit 62464dc into buschtoens:master Oct 6, 2022
@bertdeblock
Copy link
Contributor Author

@buschtoens No problem! If you have some time, would you mind cutting a release with this fix?

@Turbo87 Turbo87 added the bug Something isn't working label Dec 23, 2022
@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 23, 2022

@bertdeblock https://github.com/buschtoens/ember-link/releases/tag/v2.0.1 :)

GitHub
🐛 Bug Fix

#718 Fix exporting LinkParams and UILinkParams types (@bertdeblock)

🏠 Internal

#711 Update .npmignore file (@Turbo87)

Committers: 2

Bert De Block (@bertdeblock)
Tobias Bieniek (@turb...

@bertdeblock
Copy link
Contributor Author

Awesome, thank you @Turbo87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unfound exports LinkParams and UILinkParams under Embroider
3 participants