style: compluy with linting

addon/.eslintrc.js

@@ -1,6 +1,7 @@
-/* eslint-env node */
-
 module.exports = {
   root: true,
-  extends: '@clark/ember-typescript'
+  extends: '@clark/ember-typescript',
+  rules: {
+    '@typescript-eslint/no-invalid-this': 'off'
+  }
 };

addon/debounce.ts

@@ -1,8 +1,10 @@
 import { decoratorWithRequiredParams } from '@ember-decorators/utils/decorator';
-import { debounceTask } from 'ember-lifeline';
-import hookDisposablesRunner from './hook-disposables-runner';
 import { assert } from '@ember/debug';
 import EmberObject from '@ember/object';
+
+import { debounceTask } from 'ember-lifeline';
+
+import hookDisposablesRunner from './hook-disposables-runner';
 import privateAlias from './utils/private-alias';
 import { Prototype } from './utils/type-helpers';
 
@@ -26,7 +28,7 @@ export default decoratorWithRequiredParams(function debounce<
     key,
     desc,
     alias =>
-      function(this: InstanceType<typeof target.constructor>, ...args: any[]) {
+      function (this: InstanceType<typeof target.constructor>, ...args: any[]) {
         return debounceTask(this, alias, ...args, wait, immediate);
       }
   );

addon/disposable.ts

@@ -1,10 +1,13 @@
-import { registerDisposable } from 'ember-lifeline';
-import hookDisposablesRunner from './hook-disposables-runner';
+import { decoratorWithParams } from '@ember-decorators/utils/decorator';
 import { assert } from '@ember/debug';
-import { afterMethod } from 'patch-method';
 import EmberObject from '@ember/object';
+
+import { registerDisposable } from 'ember-lifeline';
+
+import { afterMethod } from 'patch-method';
+
+import hookDisposablesRunner from './hook-disposables-runner';
 import { Prototype } from './utils/type-helpers';
-import { decoratorWithParams } from '@ember-decorators/utils/decorator';
 
 export default decoratorWithParams(function disposable<
   Target extends Prototype<EmberObject>
@@ -20,7 +23,7 @@ export default decoratorWithParams(function disposable<
 
   hookDisposablesRunner(target.constructor);
 
-  afterMethod(target.constructor, 'init', function() {
+  afterMethod(target.constructor, 'init', function () {
     // `.bind` is required because ember-lifeline does not set the correct context
     registerDisposable(this, desc.value.bind(this));
   });

addon/event-listener.ts

@@ -1,20 +1,26 @@
 import { decoratorWithRequiredParams } from '@ember-decorators/utils/decorator';
-import { addEventListener } from 'ember-lifeline';
-import hookDisposablesRunner from './hook-disposables-runner';
+import Component from '@ember/component';
 import { assert } from '@ember/debug';
 import EmberObject from '@ember/object';
+
+import { addEventListener } from 'ember-lifeline';
+
 import { afterMethod } from 'patch-method';
-import Component from '@ember/component';
+
+import hookDisposablesRunner from './hook-disposables-runner';
 import { Prototype, Constructor } from './utils/type-helpers';
 
+// eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-empty-function
 function NOOP(): void {}
 
 function collapseProto(target: Prototype<EmberObject>) {
   // We must collapse the superclass prototype to make sure that the `actions`
   // object will exist. Since collapsing doesn't generally happen until a class is
   // instantiated, we have to do it manually.
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   if (typeof target.constructor.proto === 'function') {
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     target.constructor.proto();
   }
@@ -29,6 +35,7 @@ export default decoratorWithRequiredParams(function eventListener<
   [eventTarget, eventName, options]: [
     EventTarget | ((this: Component, obj: Component) => EventTarget),
     string,
+    // eslint-disable-next-line @typescript-eslint/ban-types
     object?
   ]
 ): PropertyDescriptor {
@@ -45,9 +52,10 @@ export default decoratorWithRequiredParams(function eventListener<
     typeof target.constructor.prototype.didInsertElement === 'function'
       ? 'didInsertElement'
       : 'init',
-    function() {
+    function () {
       addEventListener(
         this,
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         // @ts-ignore https://github.com/ember-lifeline/ember-lifeline/pull/249
         typeof eventTarget === 'function'
           ? eventTarget.call(this, this)

addon/hook-disposables-runner.ts

@@ -1,5 +1,7 @@
 import EmberObject from '@ember/object';
+
 import { runDisposables } from 'ember-lifeline';
+
 import { Constructor } from './utils/type-helpers';
 
 const hookedWithDisposables = new WeakSet<Constructor<EmberObject>>();
@@ -16,7 +18,7 @@ export default function hookDisposablesRunner(
     prototype,
     'willDestroy'
   );
-  prototype.willDestroy = function(...args: any[]) {
+  prototype.willDestroy = function (...args: any[]) {
     runDisposables(this);
     if (originalMethod) {
       return originalMethod.value.apply(this, args);

addon/later.ts

@@ -1,8 +1,10 @@
 import { decoratorWithRequiredParams } from '@ember-decorators/utils/decorator';
-import { runTask } from 'ember-lifeline';
-import hookDisposablesRunner from './hook-disposables-runner';
 import { assert } from '@ember/debug';
 import EmberObject from '@ember/object';
+
+import { runTask } from 'ember-lifeline';
+
+import hookDisposablesRunner from './hook-disposables-runner';
 import { Prototype } from './utils/type-helpers';
 
 export default decoratorWithRequiredParams(function later<

addon/schedule.ts

@@ -1,8 +1,10 @@
 import { decoratorWithRequiredParams } from '@ember-decorators/utils/decorator';
-import { scheduleTask } from 'ember-lifeline';
-import hookDisposablesRunner from './hook-disposables-runner';
 import { assert } from '@ember/debug';
 import EmberObject from '@ember/object';
+
+import { scheduleTask } from 'ember-lifeline';
+
+import hookDisposablesRunner from './hook-disposables-runner';
 import { Prototype } from './utils/type-helpers';
 
 /**

addon/throttle.ts

@@ -1,8 +1,10 @@
 import { decoratorWithRequiredParams } from '@ember-decorators/utils/decorator';
-import { throttleTask } from 'ember-lifeline';
-import hookDisposablesRunner from './hook-disposables-runner';
 import { assert } from '@ember/debug';
 import EmberObject from '@ember/object';
+
+import { throttleTask } from 'ember-lifeline';
+
+import hookDisposablesRunner from './hook-disposables-runner';
 import privateAlias from './utils/private-alias';
 import { Prototype } from './utils/type-helpers';
 
@@ -26,7 +28,7 @@ export default decoratorWithRequiredParams(function throttle<
     key,
     desc,
     alias =>
-      function(this: InstanceType<typeof target.constructor>, ...args: any[]) {
+      function (this: InstanceType<typeof target.constructor>, ...args: any[]) {
         return throttleTask(this, alias, ...args, spacing, immediate);
       }
   );

addon/utils/private-alias.ts

@@ -1,12 +1,11 @@
+// eslint-disable-next-line @typescript-eslint/ban-types
 export default function privateAlias<Target extends object>(
   target: Target,
   key: keyof Target,
   desc: PropertyDescriptor,
   makeValue: (alias: string) => any
 ): PropertyDescriptor {
-  const privateKey = `__${String(key)}-${Math.random()
-    .toString(36)
-    .slice(2)}`;
+  const privateKey = `__${String(key)}-${Math.random().toString(36).slice(2)}`;
 
   Object.defineProperty(target, privateKey, {
     ...desc,

config/ember-try.js

@@ -2,7 +2,7 @@
 
 const getChannelURL = require('ember-source-channel-url');
 
-module.exports = function() {
+module.exports = function () {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),

config/environment.js

@@ -1,5 +1,5 @@
 'use strict';
 
-module.exports = function(/* environment, appConfig */) {
+module.exports = function (/* environment, appConfig */) {
   return {};
 };

ember-cli-build.js

@@ -2,7 +2,7 @@
 
 const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
 
-module.exports = function(defaults) {
+module.exports = function (defaults) {
   const app = new EmberAddon(defaults, {
     // Add options here
   });

tests/.eslintrc.js

@@ -1,6 +1,7 @@
-/* eslint-env node */
-
 module.exports = {
   root: true,
-  extends: '@clark/ember-typescript'
+  extends: '@clark/ember-typescript/test',
+  rules: {
+    '@typescript-eslint/no-invalid-this': 'off'
+  }
 };

tests/dummy/app/app.js → tests/dummy/app/app.ts

@@ -1,14 +1,15 @@
 import Application from '@ember/application';
-import Resolver from './resolver';
+
 import loadInitializers from 'ember-load-initializers';
+
 import config from './config/environment';
+import Resolver from './resolver';
 
-const App = Application.extend({
-  modulePrefix: config.modulePrefix,
-  podModulePrefix: config.podModulePrefix,
-  Resolver
-});
+export default class App extends Application {
+  modulePrefix = config.modulePrefix;
+  podModulePrefix = config.podModulePrefix;
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  Resolver = Resolver;
+}
 
 loadInitializers(App, config.modulePrefix);
-
-export default App;

tests/dummy/app/router.ts

@@ -0,0 +1,10 @@
+import EmberRouter from '@ember/routing/router';
+
+import config from './config/environment';
+
+export default class Router extends EmberRouter {
+  location = config.locationType;
+  rootURL = config.rootURL;
+}
+
+Router.map(function () {});

tests/dummy/config/environment.js

@@ -1,6 +1,6 @@
 'use strict';
 
-module.exports = function(environment) {
+module.exports = function (environment) {
   const ENV = {
     modulePrefix: 'dummy',
     environment,

tests/helpers/in-run-loop.ts

@@ -6,11 +6,11 @@ import { begin, end } from '@ember/runloop';
  * @param {object} hooks QUnit Hooks
  */
 export default function inRunLoop(hooks: NestedHooks): void {
-  hooks.beforeEach(function() {
+  hooks.beforeEach(function () {
     begin();
   });
 
-  hooks.afterEach(function() {
+  hooks.afterEach(function () {
     end();
   });
 }

tests/integration/event-listener-test.ts

@@ -1,14 +1,17 @@
-import { module, test } from 'qunit';
-import { setupRenderingTest } from 'ember-qunit';
 import { render, click } from '@ember/test-helpers';
-import hbs from 'htmlbars-inline-precompile';
-import { eventListener } from 'ember-lifeline-decorators';
+import { setupRenderingTest } from 'ember-qunit';
+import { module, test } from 'qunit';
+
 import Component from '@ember/component';
 
-module('@eventListener', function(hooks) {
+import { eventListener } from 'ember-lifeline-decorators';
+
+import hbs from 'htmlbars-inline-precompile';
+
+module('@eventListener', function (hooks) {
   setupRenderingTest(hooks);
 
-  test('it can be used on a component', async function(assert) {
+  test('it can be used on a component', async function (assert) {
     assert.expect(1);
 
     class TestComponent extends Component {
@@ -25,7 +28,7 @@ module('@eventListener', function(hooks) {
     await click(this.element.querySelector('#test-component')!);
   });
 
-  test('it accepts `this.element` as target', async function(assert) {
+  test('it accepts `this.element` as target', async function (assert) {
     assert.expect(1);
 
     class TestComponent extends Component {
@@ -42,7 +45,7 @@ module('@eventListener', function(hooks) {
     await click(this.element.querySelector('#test-component')!);
   });
 
-  test('it calls the callback after `didInsertElement`', async function(assert) {
+  test('it calls the callback after `didInsertElement`', async function (assert) {
     assert.expect(1);
 
     let didCall = false;

tests/test-helper.js

@@ -1,8 +1,9 @@
-import Application from '../app';
-import config from '../config/environment';
 import { setApplication } from '@ember/test-helpers';
 import { start } from 'ember-qunit';
 
+import Application from '../app';
+import config from '../config/environment';
+
 setApplication(Application.create(config.APP));
 
 start();