Ignore in fastboot and document the bug for fingerprintAssetMap: true
#433
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋🏼
ember-svg-jar
's hbs strategy just got merged evoactivity/ember-svg-jar#186 and it depends on this addon to resolve the assets! while trying to document how to use the strategy for the readme I found two things:This
addon doesn't support fastboot right now, so for now at least disable. Not sure if it should though, with the prefetch stuff, maybe if we expose theLINK_ID
config to the load func, and use theshoebox
approach or something could be interesting, maybe it could be opt-in.fingerprintAssetMap: true
has a terrible bug Multiple fingerprinted assetMap.json files with v2.6.0 ember-cli/broccoli-asset-rev#122, so add documentation to the READMEWhat do you think about fastboot support? for a follow-up PR, would it make sense that it could be resolved via https://github.com/ember-fastboot/ember-cli-fastboot#the-shoebox?