feat: add support for deletion #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add character deletion support * refactor operations to operation handler * add secure flag for websockets * add shortcuts for home and end keys
* Add support for newlines. * Fix newline and deletion bugs in editor. Applied patch that changes Editor struct to have one cursor field instead of having x and y fields. Changed performOperation() to operate on the absolute cursor position, not just the x value. Fixed deletion by making cursor updating happen after the operation and removing some "-1"s from the cursor positions. * fix: update positions for home and end shortcuts Co-authored-by: Ben Muthalaly <[email protected]> Co-authored-by: burntcarrot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
HomeandEndkey shortcuts for faster navigation