fix(helm): add explicit affinity and tolerations support - #1055
Merged
burningalchemist merged 1 commit intoAug 10, 2026
Merged
Conversation
Owner
|
Hey @eenchevlp, yeah let's do it this way:
The testing workflow might fail as it's meticulously seeking for difference to avoid unexpected changes, but it's fine. 👍 |
eenchevlp
changed the title
eenchevlp
force-pushed
the
feat/helm-affinity-tolerations
branch
from
August 10, 2026 14:26
b076fd0 to
60c936d
Compare
Owner
|
@eenchevlp, wait. I apologise, I thought those values are already available. They aren't, so let's proceed as usual (basically what you had before). 😬 |
Deployment.yaml has rendered spec.template.spec.affinity and
.tolerations since the chart's original commit, but values.yaml never
documented or defaulted them, so they were unusable without knowing to
set fields helm-docs had no record of. Adds explicit `affinity: {}` and
`tolerations: []` defaults with helm-docs comments, bumps the chart
version, and regenerates README.md; no template changes needed since
rendering already worked.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
eenchevlp
force-pushed
the
feat/helm-affinity-tolerations
branch
from
August 10, 2026 14:28
60c936d to
25c1843
Compare
Contributor
Author
|
Got it @burningalchemist , PR renamed and version bump kept as-is |
burningalchemist
changed the title
Owner
|
@eenchevlp merged, thanks for your time! 😃👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@burningalchemist I am not sure if bumping chart version is worth it about this one, will remove the version increase if you decide so.
Deployment.yaml has rendered spec.template.spec.affinity and .tolerations since the chart's original commit, but values.yaml never documented or defaulted them, so they were unusable without knowing to set fields helm-docs had no record of.
Adds explicit
affinity: {}andtolerations: []defaults with helm-docs comments and regenerates README.md; no template changes needed since rendering already worked.