-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for regular expression types (re.search, re.match, re.fullmatch) in status check and metrics definition #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rics definition which allows one to select one of the regular expression types re.search, re.match or re.fullmatch Added an example buildspec and implementation for status check with different regular expression when using regex and file_regex field under status check
for more information, see https://pre-commit.ci
…t into specify_regex_type
…ng 're' property. add example buildspec for testing and schema test.
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1730 +/- ##
==========================================
+ Coverage 80.81% 80.85% +0.03%
==========================================
Files 57 57
Lines 6432 6453 +21
==========================================
+ Hits 5198 5217 +19
- Misses 1234 1236 +2 ☔ View full report in Codecov by Sentry. |
rename title of test in buildspec
…t into specify_regex_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Xiangs18 in case you start working on #1725 just be on lookout for this PR, you might get a merge conflict when you start working so just rebase