change logic of how build scripts are run #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild script will be invoked with bash without any options by default. This is true for all executor types. The generated run script will be invoked with corresponding shell type for the executor or the 'shell' property defined in the buildspec. Additional options to shell will be taken into account as well
…s failing due to syntax error
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #1670 +/- ##
==========================================
- Coverage 79.02% 78.89% -0.13%
==========================================
Files 57 57
Lines 6605 6561 -44
==========================================
- Hits 5219 5176 -43
+ Misses 1386 1385 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the following.
bashwithout any options when executing the buildscript. Previously the build script was invoked with shell type for the executor along with defined shell optionsshellkey defined in the buildspec. Any shell options specified in the executor or in buildspec will be passed to script as well.loadmethod from the LocalExecutor class