update performance check to allow for logical OR/AND check #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of assertions for comparison status check which includes ge, gt, le, lt, ne, eq. add keyword 'mode' to define if comparison is logical OR/AND. update buildspecs according to new schema and update implementation
…roperty. The 'mode' is also present for logical OR/AND
…s' property which is used to specify list of assertions. the 'mode' key is added to allow status check to be logical OR/AND. update buildspec file. update json schema definition
…n check into one method called 'comparison_check'. merge implementation of not_contains check into contains_check method
…reducing if statements. remove unused method not_contains_checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.