-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for "spack load" in spack schema #1569
Conversation
Mariamajib
commented
Jul 20, 2023
•
edited
Loading
edited
- Update spack schema to add support for load
- Add implementation of emitting spack load command in https://github.com/buildtesters/buildtest/blob/devel/buildtest/builders/spack.py.
- Add example buildspec to demonstrate this example in https://github.com/buildtesters/buildtest/tree/devel/examples/spack
- Add valid and invalid example for testing with regression test see https://github.com/buildtesters/buildtest/tree/devel/buildtest/schemas/examples/spack.schema.json please put a valid and invalid example so we can test this works during regression test
- Add documentation in https://buildtest.readthedocs.io/en/devel/buildspecs/spack.html add this at bottom of file
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #1569 +/- ##
==========================================
- Coverage 78.38% 78.27% -0.12%
==========================================
Files 57 56 -1
Lines 6597 6575 -22
==========================================
- Hits 5171 5146 -25
- Misses 1426 1429 +3
☔ View full report in Codecov by Sentry. |
…to demonstrate the example
…to demonstrate the example
…schemas.json/invalid
buildtest/schemas/examples/spack.schema.json/invalid/spack_load_invalid_example.yml
Outdated
Show resolved
Hide resolved
@Mariamajib so i would like you to add the documentation. Please add your two commands buildtest/buildtest/tools/docs.py Lines 69 to 94 in eeae018
Next please get into the container the command to run is Next run Once the files are generated please write the documentation |
remove the output from the `buildtest inspect query` command when showing results for the spack load example