Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding regression test for modules #1503

Merged
merged 12 commits into from
Jul 7, 2023
Merged

adding regression test for modules #1503

merged 12 commits into from
Jul 7, 2023

Conversation

kingxleyy
Copy link
Collaborator

No description provided.

@kingxleyy kingxleyy closed this Jun 29, 2023
@kingxleyy kingxleyy reopened this Jun 29, 2023
shahzebsiddiqui
shahzebsiddiqui requested changes Jun 29, 2023
View reviewed changes
tests/cli/test_build.py Outdated Show resolved Hide resolved
@shahzebsiddiqui shahzebsiddiqui marked this pull request as draft June 29, 2023 19:45
@kingxleyy kingxleyy changed the title adding buildtest class invoking buildtest class Jun 29, 2023
@shahzebsiddiqui shahzebsiddiqui linked an issue Jul 3, 2023 that may be closed by this pull request
Add code coverage for injecting modules on command line #1445
Closed
@kingxleyy kingxleyy changed the title invoking buildtest class adding regression test for modules Jul 5, 2023
Mendi03
Mendi03 requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@Mendi03 Mendi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment on why the regression is failing. Furthermore, you still need to invoke the class with a value for module and unload_modules.

tests/cli/test_build.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.21 🎉

Comparison is base (566e2b8) 76.46% compared to head (4e7c4d3) 76.67%.

❗ Current head 4e7c4d3 differs from pull request most recent head 9e93d10. Consider uploading reports for the commit 9e93d10 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1503      +/-   ##
==========================================
+ Coverage   76.46%   76.67%   +0.21%     
==========================================
  Files          57       57              
  Lines        6614     6614              
==========================================
+ Hits         5057     5071      +14     
+ Misses       1557     1543      -14

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Jul 6, 2023
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 7, 2023
@shahzebsiddiqui shahzebsiddiqui marked this pull request as ready for review July 7, 2023 14:05
@shahzebsiddiqui
change name of docstring and name of method
9e93d10 
change invocation of "BuildTest" when invoking test and add comment on what is being tested
@shahzebsiddiqui shahzebsiddiqui self-requested a review July 7, 2023 14:22
@shahzebsiddiqui shahzebsiddiqui merged commit 1bc8c89 into buildtesters:devel Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mendi03 Mendi03 Mendi03 requested changes

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui approved these changes

@Mariamajib Mariamajib Awaiting requested review from Mariamajib

Assignees

@kingxleyy kingxleyy

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code coverage for injecting modules on command line
3 participants
@kingxleyy @shahzebsiddiqui @Mendi03