Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor codebase of 'buildtest inspect' #1466

Merged
merged 3 commits into from
May 5, 2023

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

…md and instead invoke the method directly. Refactor the regression tests

to avoid invoking inspect_cmd method
@shahzebsiddiqui
Copy link
Member Author

@Xiangs18 based on your last PR #1387 which turned out we needed to refactor some of the code-base. I did this basically removing the entry method inspect_cmd and invoke the method directly. This caused issues with regression tests as arguments had to be passed over to several methods such as inspect_cmd -> inspect_list just to invoke a certain test. This also avoids having us to define args.

…nspect' if condition since this caused issues when report file was not present none of the commands would work
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 ⚠️

Comparison is base (2220eeb) 75.08% compared to head (8b1d3c4) 74.95%.

❗ Current head 8b1d3c4 differs from pull request most recent head 5b28edb. Consider uploading reports for the commit 5b28edb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1466      +/-   ##
==========================================
- Coverage   75.08%   74.95%   -0.13%     
==========================================
  Files          57       57              
  Lines        6537     6523      -14     
==========================================
- Hits         4908     4889      -19     
- Misses       1629     1634       +5     
Impacted Files Coverage Δ
buildtest/cli/inspect.py 96.30% <100.00%> (-2.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui shahzebsiddiqui merged commit 5c50429 into devel May 5, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the refactor_buildtest_inspect branch May 5, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant