Add implementation for 'file_count' #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arbitrary directory name and perform a reference count. Update json schema to add support for 'file_count' Update method walk_tree to allow for directory traversal to a certain depth by adding an optional argument max_depth add method search_files where one can perform directory traversal based on regular expression. The 'max_depth' argument can be supported to limit search by directory level Update regression test for walk_tree and add tests for search_files Add example buildspec for 'file_count'
…ception with invalid regular expression
add symlink in test/builders/file_count.yml to original file add docstring for each method in tests/builders/test_builders.py
…alk_tree' and 'search_tree'. numfiles will control how many files are returned that can be useful when limiting output. The file_traverse_limit controls how many files are traversed during directory walk which can be useful when going through a big directory tree or even '/' where directory walk may not be welcomed.
…s method to organize tests add method create_file that will be used for creating an empty file
…pecifying extension types. update regression test to make use of 'create_file' when creating files in 'TestSearchFiles' class
update file_count.yml example fix issue with file_count check where file count was not done correctly.
make slight changes to file_count.yml
…d to retrieve files based on files, directory or symlink. add regression coverage for this feature
…tory search by files, directory or symbolic link add example buildspec using filetype property ensure we pass file_type argument when calling walk_tree and search_files
… for regression test update method test_file_count to use the new buildspec
Codecov ReportBase: 69.16% // Head: 68.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1405 +/- ##
==========================================
- Coverage 69.16% 68.57% -0.59%
==========================================
Files 57 57
Lines 6329 6453 +124
Branches 1122 1158 +36
==========================================
+ Hits 4377 4425 +48
- Misses 1950 2026 +76
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
are traversed during directory search. add example buildspec add implementation support and update json schema
fix a bug during comparison check when calling min() function. One of the argument was a None type.
…estWalkTree where methods don't need access to 'self'
prathmesh4321
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
@shahzebsiddiqui Looks really good !. You can merge this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.