-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature buildtest buildspec find --row-count #1377
Conversation
@prathmesh4321 please try this implementation for
this is not relevant for I dont think it makes sense to have I am not sure if its useful to know total number of filter fields and format fields, if its important then potentially we add support with option |
@shahzebsiddiqui Okay, I have added --row-count option for "buildtest bc find -t", "buildtest bc find -e", "buildtest bc find -b". I don't think its useful to add --row-count option for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Rather than adding this as an option to all of your print functions I would consider instead checking for the argument in the main function and than printing the table there since all of the code is the same, but copied to different places. |
@jscook2345 so you want a top level argument Currently this is present in I thought about it when there is redundancy I think it does make sense to move this to top level argument. |
Hi @shahzebsiddiqui. I have added the "--row-count" feature for "buildtest buildspec find". Please review the PR.