Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ci on perlmutter and add method to run on perlmutter #1360

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

prathmesh4321
Copy link
Collaborator

Hi @shahzebsiddiqui . Can you please review the PR and suggest any required changes ?

@prathmesh4321 prathmesh4321 linked an issue Jan 30, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 71.22% // Head: 72.76% // Increases project coverage by +1.54% 🎉

Coverage data is based on head (8f0a9c8) compared to base (28e422d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1360      +/-   ##
==========================================
+ Coverage   71.22%   72.76%   +1.54%     
==========================================
  Files          57       57              
  Lines        6160     6160              
  Branches     1066     1066              
==========================================
+ Hits         4387     4482      +95     
+ Misses       1773     1678      -95     
Impacted Files Coverage Δ
buildtest/cli/compilers.py 74.38% <0.00%> (+46.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Jan 30, 2023

Hi @shahzebsiddiqui . Can you please review the PR and suggest any required changes ?

see CI pipeline https://software.nersc.gov/NERSC/buildtest/-/jobs/186955 it looks like it failed. You need to define an executor. Atleast for now you should have https://github.com/buildtesters/buildtest-nersc/blob/devel/config.yml#L458-L474.

You may want to define a slurm executor eventually and then start adding batch tests for slurm scheduler

@prathmesh4321
Copy link
Collaborator Author

Hi @shahzebsiddiqui . Can you please review the PR and suggest any required changes ?

see CI pipeline https://software.nersc.gov/NERSC/buildtest/-/jobs/186955 it looks like it failed. You need to define an executor. Atleast for now you should have https://github.com/buildtesters/buildtest-nersc/blob/devel/config.yml#L458-L474.

You may want to define a slurm executor eventually and then start adding batch tests for slurm scheduler

@shahzebsiddiqui I have added executors and the pipeline ran without errors. Do you want me to also add the slurm executors in this PR ?

@shahzebsiddiqui
Copy link
Member

Hi @shahzebsiddiqui . Can you please review the PR and suggest any required changes ?

see CI pipeline https://software.nersc.gov/NERSC/buildtest/-/jobs/186955 it looks like it failed. You need to define an executor. Atleast for now you should have https://github.com/buildtesters/buildtest-nersc/blob/devel/config.yml#L458-L474.
You may want to define a slurm executor eventually and then start adding batch tests for slurm scheduler

@shahzebsiddiqui I have added executors and the pipeline ran without errors. Do you want me to also add the slurm executors in this PR ?

this looks good for now but yes we probably do need to add more tests in the near future basically to replicate what was done on cori since the system will go down.

So please do add similar test to the ones found in https://github.com/buildtesters/buildtest/tree/devel/tests/examples/cori. You can ignore https://github.com/buildtesters/buildtest/blob/devel/tests/examples/cori/burstbuffer.yml test since we dont have burst buffer on Perlmutter but all other test are valid. Note the test will need to be adapted for Perlmutter.

Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for initial implementation

@shahzebsiddiqui shahzebsiddiqui merged commit 8f172b7 into devel Jan 31, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the run_ci_perlmutter branch January 31, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run CI on Perlmutter
2 participants