change executor match from equality check to regex (re.fullmatch) #1350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with validating test when
executor
property was using a regex. Current behavior was equality check with the executors defined in configuration file. This caused tests like https://github.com/buildtesters/buildtest-nersc/blob/devel/buildspecs/apps/hpctoolkit/hpctoolkit_cuda_vecadd_pc_perlmutter.yml to fail where we had the following for executor -executor: '(perlmutter|muller).slurm.regular'
With this change i was able to confirm validation and tags was picking up executors.
@wyphan with this change i expect hpctoolkit test will run now that we change executor check to
re.fullmatch