Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change executor match from equality check to regex (re.fullmatch) #1350

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui commented Jan 24, 2023

There was an issue with validating test when executor property was using a regex. Current behavior was equality check with the executors defined in configuration file. This caused tests like https://github.com/buildtesters/buildtest-nersc/blob/devel/buildspecs/apps/hpctoolkit/hpctoolkit_cuda_vecadd_pc_perlmutter.yml to fail where we had the following for executor - executor: '(perlmutter|muller).slurm.regular'

With this change i was able to confirm validation and tags was picking up executors.

(buildtest)  ~/gitrepos/buildtest-nersc/ [devel] buildtest bc find --filter buildspec=/global/u1/s/siddiq90/gitrepos/buildtest-nersc/buildspecs/apps/hpctoolkit/hpctoolkit_cuda_vecadd_perlmutter.yml
          Buildspec Cache: /global/u1/s/siddiq90/gitrepos/buildtest/var/buildspecs/cache.json
 name            ┃ type   ┃ executor                          ┃ tags ┃ description
━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 hpctoolkit_cuda │ script │ (perlmutter|muller).slurm.regular │ e4s  │ HPCToolkit vector add CUDA test

@wyphan with this change i expect hpctoolkit test will run now that we change executor check to re.fullmatch

… valid when used with regular expression otherwise the equality match doesnt work

with string comparison
@shahzebsiddiqui shahzebsiddiqui self-assigned this Jan 24, 2023
@shahzebsiddiqui shahzebsiddiqui merged commit 416ee56 into devel Jan 24, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the change_executor_match branch January 24, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant