Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move implementation of all status checks #1332

Merged
merged 5 commits into from
Jan 6, 2023

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

…ists_check since

we can reference builder object to retrieve status property.

update docstring for all methods for perf checks
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 71.21% // Head: 71.41% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (13a96e3) compared to base (f0386e9).
Patch coverage: 8.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1332      +/-   ##
==========================================
+ Coverage   71.21%   71.41%   +0.20%     
==========================================
  Files          57       57              
  Lines        6106     6093      -13     
  Branches     1089     1081       -8     
==========================================
+ Hits         4348     4351       +3     
+ Misses       1756     1740      -16     
  Partials        2        2              
Impacted Files Coverage Δ
buildtest/buildsystem/checks.py 8.11% <8.02%> (-7.52%) ⬇️
buildtest/builders/base.py 57.43% <10.00%> (+13.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui shahzebsiddiqui merged commit edd3506 into devel Jan 6, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the refactor_status_checks branch January 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant