Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression test with validating module tool on cori and ascent #1324

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

…nd ascent since we need to

pass 'moduletool' parameter when calling SiteConfiguration.validate()
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 72.10% // Head: 80.68% // Increases project coverage by +8.59% 🎉

Coverage data is based on head (2e0de81) compared to base (c57eca0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1324      +/-   ##
==========================================
+ Coverage   72.10%   80.68%   +8.59%     
==========================================
  Files          56       56              
  Lines        6021     6021              
  Branches     1071     1114      +43     
==========================================
+ Hits         4341     4858     +517     
+ Misses       1678     1162     -516     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
buildtest/cli/cdash.py 89.60% <0.00%> (+0.99%) ⬆️
buildtest/buildsystem/builders.py 78.31% <0.00%> (+1.81%) ⬆️
buildtest/cli/build.py 94.97% <0.00%> (+2.69%) ⬆️
buildtest/builders/script.py 78.21% <0.00%> (+5.13%) ⬆️
buildtest/executors/base.py 96.97% <0.00%> (+9.09%) ⬆️
buildtest/builders/base.py 60.10% <0.00%> (+12.54%) ⬆️
buildtest/scheduler/job.py 85.71% <0.00%> (+14.29%) ⬆️
buildtest/config.py 64.32% <0.00%> (+14.57%) ⬆️
buildtest/executors/setup.py 90.82% <0.00%> (+17.87%) ⬆️
buildtest/system.py 78.79% <0.00%> (+23.74%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui shahzebsiddiqui merged commit 24879dc into devel Dec 22, 2022
@shahzebsiddiqui shahzebsiddiqui deleted the fix_facility_regtest_nersc_olcf branch December 22, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant