Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for buildtest report clear #1299

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Add coverage for buildtest report clear #1299

merged 4 commits into from
Dec 2, 2022

Conversation

prathmesh4321
Copy link
Collaborator

@prathmesh4321 prathmesh4321 commented Nov 17, 2022 •
edited
Loading

Screen Shot 2022-11-17 at 2 25 04 PM

@prathmesh4321 prathmesh4321 linked an issue Nov 17, 2022 that may be closed by this pull request
add regression coverage for buildtest report clear #1281
Closed
@prathmesh4321 prathmesh4321 changed the title Add test coverage for buildtest report clear Add coverage for buildtest report clear Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Base: 73.08% // Head: 73.21% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (3b18650) compared to base (5bd382d).
Patch has no changes to coverable lines.

❗ Current head 3b18650 differs from pull request most recent head 3ec746c. Consider uploading reports for the commit 3ec746c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1299      +/-   ##
==========================================
+ Coverage   73.08%   73.21%   +0.12%     
==========================================
  Files          55       55              
  Lines        5885     5886       +1     
  Branches      997      997              
==========================================
+ Hits         4301     4309       +8     
+ Misses       1584     1577       -7
Impacted Files Coverage Δ
buildtest/cli/report.py 90.59% <ø> (+1.88%) ⬆️
buildtest/cli/buildspec.py 94.86% <0.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

shahzebsiddiqui
shahzebsiddiqui approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzebsiddiqui shahzebsiddiqui merged commit cef47a5 into devel Dec 2, 2022
@shahzebsiddiqui shahzebsiddiqui deleted the issue_1281 branch December 2, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add regression coverage for buildtest report clear
2 participants
@prathmesh4321 @shahzebsiddiqui