-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option buildtest --helpcolor to show available color options in table format #1277
Conversation
Codecov ReportBase: 77.99% // Head: 81.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1277 +/- ##
==========================================
+ Coverage 77.99% 81.28% +3.28%
==========================================
Files 54 55 +1
Lines 5935 5944 +9
Branches 1026 1071 +45
==========================================
+ Hits 4629 4831 +202
+ Misses 1305 1113 -192
+ Partials 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing can you please add a section for documentation. Perhaps you can mention this in https://buildtest.readthedocs.io/en/devel/features.html
Done ! @shahzebsiddiqui |
@prathmesh4321 question about the image you uploaded about the I was looking at the generated docs https://buildtest--1277.org.readthedocs.build/en/1277/features.html#listing-available-color-options-buildtest-helpcolor and it looks nice but i am thinking we shouldnt have this output. Let's follow up on slack and would like to get your opinion on the docs |
@shahzebsiddiqui I have added the command instead of the picture. Let me know if that looks right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I rephrased one sentence but this looks good.
No description provided.