Support combined exporter/cacher and reversed analyzer/restorer. #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for Platform API Version 0.2 * Extend the incompatible-platform-version check to include a minimum-supported version. * When encountering lifecycle with platform API version 0.2 and above: * Stop requiring cacher when creating a new builder. * Remove cacher build phase. * Reorder analyzer and restorer build phases. * Change the -path cache flag name to -cache-dir. Signed-off-by: Lukas Berger <[email protected]>
lukasberger
force-pushed
the
combined-exporter-cacher-2
branch
from
b61580b to
f2078ac
Compare
Contributor
Author
|
This is an attempt to add "expocacher" support for pack while maintaining compatibility with the current platform API version. Any suggestions on how this can be made clearer appreciated! |
Signed-off-by: Lukas Berger <[email protected]>
jromero
suggested changes
Nov 15, 2019
Member
jromero
left a comment
jromero
left a comment
There was a problem hiding this comment.
Overall looks good just a few concern about how to present it. Thanks for spearheading this!
Remove the misleading MinPlatformAPIVersion variable in favor of a supported versions slice. Signed-off-by: Lukas Berger <[email protected]>
Signed-off-by: Lukas Berger <[email protected]>
jromero
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #372